Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-4529] notification emails #2947

Open
wants to merge 13 commits into
base: feature/EASI-4521_grb_presentation_links
Choose a base branch
from
Open

[EASI-4529] notification emails #2947

wants to merge 13 commits into from
+197 −14

Conversation

samoddball
Copy link
Contributor

EASI-4529

Description

  • build out template + template code for notification emails when links are updated

How to test this change

  • for now, run tests and confirm pass
  • later, we will test this once resolvers are hooked up

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@samoddball samoddball requested a review from a team as a code owner January 8, 2025 18:06
@samoddball samoddball requested review from mynar7 and removed request for a team January 8, 2025 18:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

EKS Ingress URLs

samoddball
samoddball commented Jan 8, 2025
View reviewed changes
pkg/email/grb_review_discussion_group_tagged.go
@@ -45,7 +45,7 @@ type GRBReviewDiscussionGroupTaggedBody struct {

func (sie systemIntakeEmails) grbReviewDiscussionGroupTaggedBody(input SendGRBReviewDiscussionGroupTaggedEmailInput) (string, error) {
if sie.client.templates.grbReviewDiscussionGroupTagged == nil {
return "", errors.New("grb review discussion reply template is nil")
return "", errors.New("grb review discussion group tagged template is nil")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed err msg

samoddball
samoddball commented Jan 8, 2025
View reviewed changes
pkg/email/grb_review_discussion_individual_tagged.go
@@ -42,7 +42,7 @@ type GRBReviewDiscussionIndividualTaggedBody struct {

func (sie systemIntakeEmails) grbReviewDiscussionIndividualTaggedBody(input SendGRBReviewDiscussionIndividualTaggedEmailInput) (string, error) {
if sie.client.templates.grbReviewDiscussionIndividualTagged == nil {
return "", errors.New("grb review discussion reply template is nil")
return "", errors.New("grb review discussion individual tagged template is nil")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed err msg

mynar7
mynar7 requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@mynar7 mynar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for some adjustments needed on the template to match the figma. If you wouldn't mind, it looks like the SendSystemIntakeAdminUploadDocEmail notification template could use similar changes as well.

pkg/email/templates/grb_review_presentation_links_updated.gohtml Outdated Show resolved Hide resolved
pkg/email/templates/grb_review_presentation_links_updated.gohtml Outdated Show resolved Hide resolved
@samoddball @mynar7
Update pkg/email/templates/grb_review_presentation_links_updated.gohtml
04d01fe 
Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com>
@samoddball
Copy link
Contributor Author

Looks good except for some adjustments needed on the template to match the figma. If you wouldn't mind, it looks like the SendSystemIntakeAdminUploadDocEmail notification template could use similar changes as well.

good call - added changes for SendSystemIntakeAdminUploadDocEmail too. thanks!

@samoddball samoddball requested a review from mynar7 January 14, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 Awaiting requested review from ClayBenson94

@mynar7 mynar7 Awaiting requested review from mynar7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samoddball @mynar7